Skip to content

Integration test running ingesters #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 25, 2019
Merged

Integration test running ingesters #1271

merged 9 commits into from
Aug 25, 2019

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Mar 9, 2019

A first cut. Attempting to keep things lightweight, e.g. no Kubernetes.

The test client is at https://github.com/bboreham/avalanche/tree/remote-write

You may say "that's an ugly pile of shell script, Bryan", and I might well agree with you.
It lets me iterate quickly.

@bboreham bboreham force-pushed the integration-tests branch 4 times, most recently from 412c38c to 17740e5 Compare March 9, 2019 16:42
@csmarchbanks
Copy link
Contributor

I am excited to see how this turns out. Also, if you want to make a PR for the avalanche work ping me in it and I will take a look. Since there seems to be some interest in Avalanche we will do some updates to it soon.

@bboreham bboreham force-pushed the integration-tests branch from 5cb8146 to c7a78d3 Compare April 25, 2019 09:17
@bboreham bboreham force-pushed the integration-tests branch from c7a78d3 to 9b18e44 Compare May 14, 2019 17:58
@bboreham bboreham force-pushed the integration-tests branch 2 times, most recently from 6890fb5 to 817edb8 Compare June 12, 2019 15:04
@bboreham bboreham force-pushed the integration-tests branch 8 times, most recently from 02ef633 to 54adb67 Compare August 13, 2019 11:27
@bboreham bboreham marked this pull request as ready for review August 13, 2019 11:28
Running table-manager, distributors and ingesters, creating tables and
running the hand-over process between ingesters.

Signed-off-by: Bryan Boreham <[email protected]>
Need to move the 'images' directory to /tmp since /go isn't writeable
in 'machine' executor type on CircleCI.  Indirect via symlink so we
can run the Makefile unchanged from the project directory.

The Postgres container we were running seems to have been ignored,
since the Makefile always runs another one.

Signed-off-by: Bryan Boreham <[email protected]>
Shell variables don't persist from one Makefile line to the next, so
we need to combine the commands into one line.

Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with these as they are and look forward to having some high level tests.

I am curious, why sh rather than using go?

DIST_ADDR=$(container_ip distributor)
wait_for "has_tokens_owned $DIST_ADDR" "distributor to see ingester in ring"

docker run $RUN_ARGS --rm weaveworks/avalanche:remote-write --metric-count=2 --label-count=2 --series-count=2 --remote-url=http://distributor/api/prom/push
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bboreham
Copy link
Contributor Author

why sh rather than using go?

I'm very used to working this way, from experience with Weave Net; it lets me iterate quickly. Part of it is I don't have a good framework in Go for starting processes, waiting for status, etc., and part I don't have a good toolset for interrupting Go programs, inspecting, status, re-running parts, etc.

Happy to take suggestions for tooling. It's only 100 lines of shell script so should be possible to rewrite in Go in less than 1,000 😜

Available images need an additional flag to get same behaviour.

Signed-off-by: Bryan Boreham <[email protected]>
@bboreham bboreham merged commit 9349981 into master Aug 25, 2019
@bboreham bboreham deleted the integration-tests branch August 25, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants